Skip to content
This repository was archived by the owner on Jun 5, 2020. It is now read-only.

Added support for centos-7, and fixed quite a lot bugs. - #87

Open
ashish1099 wants to merge 1 commit into
puppetlabs-toy-chest:masterfrom
ashish1099:master
Open

Added support for centos-7, and fixed quite a lot bugs.#87
ashish1099 wants to merge 1 commit into
puppetlabs-toy-chest:masterfrom
ashish1099:master

Conversation

@ashish1099

@ashish1099 ashish1099 commented May 28, 2015

Copy link
Copy Markdown
  1. Install passenger with specified version by user
  2. Removed variable which are not required.
  3. Added some package dependencies
  4. Used "unless" because compile fails with "exit status 0"
  5. Fixed apache module conf files

@ashish1099
Added support for centos-7, and fixed quite a lot bugs, 1. install pa…
6a607a2 
…ssenger with specified version by user, removed not required variable and lot more
@ashish1099

ashish1099 commented May 28, 2015

Copy link
Copy Markdown
Author

The travis build is failing because of this error

The command "bundle exec rake validate && bundle exec rake lint && bundle exec rake spec SPEC_OPTS='--color --format documentation'" exited with 1

DavidS
DavidS reviewed Jul 3, 2015
View reviewed changes
Comment thread manifests/compile.pp

@DavidS DavidS Jul 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant with the creates check in L7; if actually requiring a file (and not a symlink or directory) here is necessary, please remove the creates

@DavidS

DavidS commented Jul 3, 2015

Copy link
Copy Markdown
Contributor

The actual travis errors can be seen right above that line:

manifests/compile.pp - WARNING: variable not enclosed in {} on line 8
manifests/options.pp - WARNING: case statement without a default case on line 33
manifests/options.pp - WARNING: double quoted string containing no variables on line 35
manifests/options.pp - WARNING: double quoted string containing no variables on line 40
manifests/options.pp - WARNING: variable not enclosed in {} on line 18
manifests/options.pp - WARNING: variable not enclosed in {} on line 19
manifests/options.pp - WARNING: variable not enclosed in {} on line 42
manifests/options.pp - WARNING: variable not enclosed in {} on line 53
manifests/options.pp - WARNING: variable not enclosed in {} on line 54

and should be trivial to fix.

I do not quite understand why all that code needs to move from params to options.

@ashish1099

ashish1099 commented Jul 3, 2015

Copy link
Copy Markdown
Author

@DavidS make sense, i will update it

DavidS
DavidS reviewed Jul 3, 2015
View reviewed changes
Comment thread manifests/install.pp

@DavidS DavidS Jul 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this line the only actual fix for MODULES-2072?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

backwards-incompatible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashish1099 @DavidS